Fix 3.13.14 / 3.14.6 build failures#12
Merged
Merged
Conversation
Two CI failures from the 3.13.13->3.13.14 / 3.14.5->3.14.6 bump: 1. iOS 3.13 build: ios_patches/3.13/Python.patch (Apple-tooling back-port) no longer applied to 3.13.14 — 3.13.14 reworked the AC_CHECK_FUNCS block in configure/configure.ac (moved dup3/pipe2 into the non-iOS conditional), so 1/43 configure and 3/36 configure.ac hunks failed. Regenerated the configure + configure.ac sections of the patch against 3.13.14, merging the back-port's tvOS/visionOS/watchOS handling with 3.13.14's dup3/pipe2 move. Validated: applies clean (patch -p1 --force, 0 rejects) to pristine 3.13.14. 2. Linux + Android jobs failed at "Setup Python": GitHub's hosted-runner manifest doesn't yet have 3.13.14/3.14.6, so installing the full version errored. The host interpreter is only a build driver (minor version is all that matters), so install PYTHON_VERSION_SHORT instead — matching what the Darwin and Windows jobs already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 3.13.13→3.13.14 / 3.14.5→3.14.6 bump (#11), which broke CI (run). Two independent root causes:
1. iOS 3.13 build — patch no longer applied
darwin/ios_patches/3.13/Python.patchback-ports CPython's Apple build tooling and was generated against 3.13.13. CPython 3.13.14 reworked theAC_CHECK_FUNCSblock inconfigure/configure.ac(it moveddup3/pipe2into the non-iOS conditional), so the patch failed:Regenerated the
configure+configure.acsections of the patch against 3.13.14, merging the back-port's tvOS/visionOS/watchOSAC_CHECK_FUNCShandling with 3.13.14'sdup3/pipe2move (both forced off across all four embedded Apple platforms). Everything else in the patch (the Apple/ tooling files) is byte-for-byte unchanged.Validation: the regenerated patch applies with
patch -p1 --forceagainst a pristine 3.13.14 source tree with 0 rejects, and produces a tree identical to the reference.2. Linux + Android —
Setup PythonfailedGitHub's hosted-runner Python manifest doesn't carry freshly-released patch versions yet. These jobs installed the full version; the host interpreter is only a build driver (the target Python is built from source / fetched as python-build-standalone), so only the minor version matters. Switched them to
PYTHON_VERSION_SHORT— matching what the Darwin and Windows jobs already do. Also future-proofs against the manifest lagging on later bumps.Not changed